docs: note MariaDB support in README#13238
Conversation
Document that CloudStack uses a MySQL-compatible database (MariaDB or MySQL) and point to the Docker dev compose file that uses MariaDB. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
bernardodemarco
left a comment
bernardodemarco
left a comment
There was a problem hiding this comment.
@robertsilen, thanks for the PR!
@robertsilen, do you think it is required to mention that The Docker development setup in tools/docker/docker-compose.yml uses MariaDB? I think that only mentioning that both MariaDB and MySQL are supported would be enough here
+1 I think that something like this would be better: |
Drop the Docker compose reference; state MySQL-compatible (MariaDB or MySQL) support only. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@bernardodemarco @winterhazel Thanks for the review — agreed. I've dropped the Docker compose reference and simplified the line to:
Pushed to the branch. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13238 +/- ##
============================================
+ Coverage 18.10% 18.11% +0.01%
- Complexity 16746 16758 +12
============================================
Files 6037 6037
Lines 542933 542783 -150
Branches 66487 66454 -33
============================================
+ Hits 98283 98322 +39
+ Misses 433602 433416 -186
+ Partials 11048 11045 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
Summary
Documents that CloudStack uses a MySQL-compatible database. The Docker development setup in
tools/docker/docker-compose.ymluses MariaDB (mariadb:10.0); the README only mentioned MySQL in the cryptographic software notice.Documentation only; no code or deployment changes.
Test plan